Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 1/3] macvlan: Reflect macvlan packets meant for other macvlan devices | Date | Thu, 19 Nov 2009 12:44:43 +0100 |
| |
On Thursday 19 November 2009, Eric W. Biederman wrote: > > It seems that we should never drop dst then. We either forward the frame to > > netif_rx or to dev_queue_xmit, and from how I read it now, we want to keep > > the dst in both cases. > > When we loop back on our selves we certainly need to have dst clear because > we don't know how to cache routes through multiple network namespaces.
Ah, right. So should I add the explicit dst_drop to the new dev_forward_skb() then? The veth driver doesn't need it, but it also looks like it won't hurt.
Arnd <><
| |