Messages in this thread | | | From | Rusty Russell <> | Subject | Re: virtio: Add memory statistics reporting to the balloon driver (V3) | Date | Fri, 20 Nov 2009 10:23:30 +1030 |
| |
On Fri, 20 Nov 2009 01:49:05 am Adam Litke wrote: > Rusty and Anthony, > If I've addressed all outstanding issues, please consider this patch for > inclusion. Thanks. > > Changes since V2: > - Increase stat field size to 64 bits > - Report all sizes in kb (not pages)
Hi Adam,
Looks like we're very close. A few minor things:
Why k? Why not just do the simplest possible thing, and just report all stats as straight numbers, now we have 64 bits.
> - Drop anon_pages stat and fix endianness conversion
Please drop endianness conversion.
> +struct virtio_balloon_stat > +{ > + __le16 tag; > + __le64 val; > +};
Let's not introduce padding as well; __attribute__((packed)) here please.
Thanks, Rusty.
| |