Messages in this thread | | | Date | Thu, 19 Nov 2009 13:19:51 -0800 (PST) | Subject | Re: [PATCH 2.6.32-rc6] drivers/net: ks8851_mll ethernet network driver | From | David Miller <> |
| |
From: David Miller <davem@davemloft.net> Date: Thu, 19 Nov 2009 12:27:34 -0800 (PST)
> From: "Choi, David" <David.Choi@Micrel.Com> > Date: Tue, 17 Nov 2009 15:02:36 -0800 > >> This patch is for ks8851 16bit MLL Ethernet network device driver in order to fix bugs and to enhance functions. > ... >> Signed-off-by: David J. Choi <david.choi@micrel.com> > > Applied.
Sorry I had to revert this, it adds new warnings to the build.
You can't cast pointers to 'int' in order to print them, that emits a warning on 64-bit systems because you're truncating the top bits.
There is really no point in printing __iomem pointers, those are very architecture specific. So is the IRQ number.
I would just remove this part of your patch entirely (don't forget to update the commit message to match).
Please fix this up and resubmit, thank you.
| |