Messages in this thread |  | | | Date | Thu, 19 Nov 2009 15:38:47 +0100 | | From | Jan Kara <> | | Subject | Re: [PATCH] ext2: Explicitly assign values to on-disk enum of filetypes |
| |
On Wed 18-11-09 23:34:46, Andreas Dilger wrote: > On 2009-11-18, at 08:25, Jan Blunck wrote: > >Here is an old patch that I found in my tree. Andreas, it seems > >that this is something you proposed. > > > >Comments? > > This is definitely my preferred coding style for constants that form > a permanent part of the API/ABI/disk format. > > The enum is useful because some debuggers can display the symbolic > name of a constant if a named enum is present (though in this case > it isn't), but it avoids the risk of someone accidentally inserting > or removing a value in the middle of the enum. In this particular case, I don't have a strong opinion... There isn't much churn in FT_ fields but OTOH it doesn't hurt to have numbers explicitely assigned and as you write for on-disk format it's really important to have them fixed. OK, probably I'm slightly in favor of merging the patch so I've queued it up.
Honza -- Jan Kara <jack@suse.cz> SUSE Labs, CR
|  |