Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 6/7] cifs: Don't use PF_MEMALLOC | Date | Wed, 18 Nov 2009 15:31:19 +0900 (JST) |
| |
> It is hard to follow exactly what this flag does in /mm (other than try > harder on memory allocations) - I haven't found much about this flag (e.g. > http://lwn.net/Articles/246928/) but it does look like most of the fs no > longer set this (except xfs) e.g. ext3_ordered_writepage. When running out > of memory in the cifs_demultiplex_thread it will retry 3 seconds later, but > if memory allocations ever fail in this path we could potentially be holding > up (an already issued write in) writepages for that period by not having > memory to get the response to see if the write succeeded. > > We pass in few flags for these memory allocation requests: GFP_NOFS (on the > mempool_alloc) and SLAB_HWCACHE_ALIGN (on the kmem_cache_create of the pool) > should we be passing in other flags on the allocations?
I don't think you need change more.
| |