Messages in this thread | | | Date | Tue, 17 Nov 2009 11:12:26 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [PATCH] strcmp: fix overflow error |
| |
On Tue, 17 Nov 2009, Linus Torvalds wrote: > > Yeah, I looked at the history too. It's so old that it might well be me.
In fact, it goes back to at least 1.2.13.
And the copyright dates do imply that they could go back way further.
At least the comment says it all:
"These are buggy as well.."
so I can at least claim that back in the _original_ 0.01 release, it was correct:
extern inline int strcmp(const char * cs,const char * ct) { register int __res __asm__("ax"); __asm__("cld\n" "1:\tlodsb\n\t" "scasb\n\t" "jne 2f\n\t" "testb %%al,%%al\n\t" "jne 1b\n\t" "xorl %%eax,%%eax\n\t" "jmp 3f\n" "2:\tmovl $1,%%eax\n\t" "jl 3f\n\t" "negl %%eax\n" "3:" :"=a" (__res):"D" (cs),"S" (ct):"si","di"); return __res; }
and as far as I can tell, the above is actually correct, even if you have to be a bit crazy to write 'strcmp' as gcc inline asm (hey, I wrote _all_ the string routines that way, and I made gcc do some of them built-in. Because I was a MAN, dammit!).
So the bug was apparently introduced when we went portable.
Linus
| |