lkml.org 
[lkml]   [2009]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] kbd: (#7063) make CapsLock work as expected even for non-ASCII
    Alexey Dobriyan, le Tue 17 Nov 2009 14:55:03 +0300, a écrit :
    > On Tue, Nov 17, 2009 at 12:15:20AM +0100, Samuel Thibault wrote:
    > > Alexey Dobriyan, le Tue 17 Nov 2009 02:05:23 +0300, a écrit :
    > > > On Mon, Nov 16, 2009 at 11:54:29PM +0100, Samuel Thibault wrote:
    > > > > Samuel Thibault, le Mon 16 Nov 2009 23:27:38 +0100, a écrit :
    > > > > > > My keymap contains
    > > > > > >
    > > > > > > keycode 44 = +z
    > > > > > > shift keycode 44 = +Z
    > > > > > > altgr keycode 44 = U+044F # CYRILLIC SMALL LETTER YA
    > > > > > > altgr shift keycode 44 = U+042F # CYRILLIC CAPITAL LETTER YA
    > > > > >
    > > > > > And U+044F / U+042F is not KT_LETTER.
    > > > > >
    > > > > > Yes, there's no way you can express a unicode character in KT_LETTER.
    > > > > > Limited interface, but that's not a reason to break other interfaces.
    > > > >
    > > > > One way to go would be to decrete that keysyms between 0xD800 and 0xE000
    > > >
    > > > And this is going to help me with U+042F/U+044F how?
    >
    > > --- a/drivers/char/keyboard.c
    > > +++ b/drivers/char/keyboard.c
    > > @@ -1258,6 +1258,15 @@ static void kbd_keycode(unsigned int keycode, int down, int hw_raw)
    > > type = KTYP(keysym);
    > >
    > > if (type < 0xf0) {
    > > + if (keysym >= 0xD800 && keysym < 0xE000) {
    >
    > keysym is 0x044F at this point.

    I'm precisely suggesting that instead of 0x044F, the keymap provides
    0xdc4f, just like for +z the keysym is not K(KT_LATIN,0x0079), but
    K(KT_LETTER,0x79) (that's the difference between just z and +z, i.e.
    whether it's KT_LATIN or KT_LETTER, i.e. whether capslock acts on it or
    not, that's the whole point of capslock vs shift lock!).

    More precisely, in the kbd source code, in the add_capslock function, in
    the unicode case, instead of ignoring the '+', add 0xD800 to the unicode
    value if it is below 0x0800.

    But again, that's a very limited fix and just fixing the LED interface
    would allow to just use modifiers and permit much more powerful keymaps.

    Samuel
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-11-17 14:27    [W:0.194 / U:0.496 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site