Messages in this thread Patch in this message | | | From | Mel Gorman <> | Subject | [PATCH 2/4] powerpc: Panic on platform ppc-xicp when CONFIG_XICS not set instead of build failure | Date | Tue, 17 Nov 2009 12:07:37 +0000 |
| |
If CONFIG_XICS is not set but CONFIG_PPC_PSERIES is, then the kernel fails to build with
arch/powerpc/platforms/pseries/smp.c: In function ‘smp_init_pseries_xics’: arch/powerpc/platforms/pseries/smp.c:202: error: ‘pSeries_xics_smp_ops’ undeclared (first use in this function) arch/powerpc/platforms/pseries/smp.c:202: error: (Each undeclared identifier is reported only once arch/powerpc/platforms/pseries/smp.c:202: error: for each function it appears in.) make[2]: *** [arch/powerpc/platforms/pseries/smp.o] Error 1
As CONFIG_XICS is not always necessary, this patch allows the kernel to build but the system will panic at runtime if it is found that XICS is required.
Signed-off-by: Mel Gorman <mel@csn.ul.ie> --- arch/powerpc/platforms/pseries/smp.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/platforms/pseries/smp.c b/arch/powerpc/platforms/pseries/smp.c index 440000c..da78ea5 100644 --- a/arch/powerpc/platforms/pseries/smp.c +++ b/arch/powerpc/platforms/pseries/smp.c @@ -199,7 +199,11 @@ void __init smp_init_pseries_mpic(void) void __init smp_init_pseries_xics(void) { +#ifdef CONFIG_XICS smp_ops = &pSeries_xics_smp_ops; +#else + panic("Support for platform ppc-xicp not configured"); +#endif smp_init_pseries(); } -- 1.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |