lkml.org 
[lkml]   [2009]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH 2.6.32-rc7] Remove kmem_cache_destroy() in s3c24xx_dma_init().
From
Date
Will you send below patch to upstream?

Regards.
--------------------
[PATCH 2.6.32-rc7] Remove kmem_cache_destroy() in s3c24xx_dma_init().

kmem_cache_destroy() in s3c24xx_dma_init() triggers NULL pointer dereference
if kmem_cache_create() failed. We can remove this kmem_cache_destroy() because
it is called only when kmem_cache_create() failed.

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
---
arch/arm/plat-s3c24xx/dma.c | 1 -
1 file changed, 1 deletion(-)

--- linux-2.6.30-rc6.orig/arch/arm/plat-s3c24xx/dma.c
+++ linux-2.6.30-rc6/arch/arm/plat-s3c24xx/dma.c
@@ -1396,7 +1396,6 @@ int __init s3c24xx_dma_init(unsigned int
return 0;

err:
- kmem_cache_destroy(dma_kmem);
iounmap(dma_base);
dma_base = NULL;
return ret;

\
 
 \ /
  Last update: 2009-11-16 12:17    [W:0.031 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site