Messages in this thread Patch in this message | | | Date | Tue, 17 Nov 2009 00:15:20 +0100 | From | Samuel Thibault <> | Subject | Re: [PATCH] kbd: (#7063) make CapsLock work as expected even for non-ASCII |
| |
Alexey Dobriyan, le Tue 17 Nov 2009 02:05:23 +0300, a écrit : > On Mon, Nov 16, 2009 at 11:54:29PM +0100, Samuel Thibault wrote: > > Samuel Thibault, le Mon 16 Nov 2009 23:27:38 +0100, a écrit : > > > > My keymap contains > > > > > > > > keycode 44 = +z > > > > shift keycode 44 = +Z > > > > altgr keycode 44 = U+044F # CYRILLIC SMALL LETTER YA > > > > altgr shift keycode 44 = U+042F # CYRILLIC CAPITAL LETTER YA > > > > > > And U+044F / U+042F is not KT_LETTER. > > > > > > Yes, there's no way you can express a unicode character in KT_LETTER. > > > Limited interface, but that's not a reason to break other interfaces. > > > > One way to go would be to decrete that keysyms between 0xD800 and 0xE000 > > And this is going to help me with U+042F/U+044F how?
This way:
diff --git a/drivers/char/keyboard.c b/drivers/char/keyboard.c index 737be95..264db17 100644 --- a/drivers/char/keyboard.c +++ b/drivers/char/keyboard.c @@ -1258,6 +1258,15 @@ static void kbd_keycode(unsigned int keycode, int down, int hw_raw) type = KTYP(keysym); if (type < 0xf0) { + if (keysym >= 0xD800 && keysym < 0xE000) { + /* Surrogates in Unicode, here KT_LETTER variants of unicode U+0000-U+07FF */ + keysym -= 0xD800; + if (vc_kbd_led(kbd, VC_CAPSLOCK)) { + key_map = key_maps[shift_final ^ (1 << KG_SHIFT)]; + if (key_map) + keysym = key_map[keycode]; + } + } param.value = keysym; if (atomic_notifier_call_chain(&keyboard_notifier_list, KBD_UNICODE, ¶m) == NOTIFY_STOP) return; Which BTW is correct while the proposed patch earlier wasn't: the param.value needs to be the final keysym.
But again, that only solves the problem of the limited range U+0000-U+0800 and doesn't solve the é/É french keyboard problem. Adding an interface to change the modifier lock / LED assignation would on the other hand permit kbd and console-setup to properly do proper capslock processing correctly.
Samuel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |