Messages in this thread | | | Date | Mon, 16 Nov 2009 14:14:26 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] microblaze: Fix pfn_valid() for noMMU |
| |
On Fri, 13 Nov 2009 16:08:29 -0600 steve@digidescorp.com wrote:
> Configuring DEBUG_SLAB causes a noMMU kernel to die during initialization > with an invalid virtual address panic in kfree_debugcheck(). > The panic is due to an improper definition of pfn_valid(). > > Signed-off-by: Steven J. Magnani <steve@digidescorp.com> > --- > diff -uprN a/arch/microblaze/include/asm/page.h b/arch/microblaze/include/asm/page.h > --- a/arch/microblaze/include/asm/page.h 2009-09-09 17:13:59.000000000 -0500 > +++ b/arch/microblaze/include/asm/page.h 2009-11-13 15:20:26.000000000 -0600 > @@ -161,7 +161,8 @@ extern int page_is_ram(unsigned long pfn > # endif /* CONFIG_MMU */ > > # ifndef CONFIG_MMU > -# define pfn_valid(pfn) ((pfn) >= min_low_pfn && (pfn) <= max_mapnr) > +# define pfn_valid(pfn) (((pfn) >= min_low_pfn) && \ > + ((pfn) <= (min_low_pfn + max_mapnr))) > # define ARCH_PFN_OFFSET (PAGE_OFFSET >> PAGE_SHIFT) > # else /* CONFIG_MMU */ > # define ARCH_PFN_OFFSET (memory_start >> PAGE_SHIFT)
Is arch/score/include/asm/page.h buggy also?
| |