Messages in this thread | | | Date | Mon, 16 Nov 2009 13:27:55 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 3/6] INIT: Limit the number of per cpu calibration bootup messages |
| |
On 11/16/2009 01:24 PM, Ingo Molnar wrote: > > * Mike Travis <travis@sgi.com> wrote: > >> --- linux.orig/init/calibrate.c >> +++ linux/init/calibrate.c >> @@ -123,23 +123,26 @@ >> { >> unsigned long ticks, loopbit; >> int lps_precision = LPS_PREC; >> + bool boot_cpu = (smp_processor_id() == 0); > > this code is shared by other architectures too - are you sure > smp_processor_id()==0 is a proper 'I am the boot CPU' assumption > everywhere? >
It really shouldn't be for x86 either, although right now we play nasty renumbering games to accommodate that assumption. It seems like we really should have a boot_cpu_id() or some such.
-hpa
| |