Messages in this thread |  | | | Date | Mon, 16 Nov 2009 16:09:37 +0100 | | From | Ingo Molnar <> | | Subject | Re: [PATCH] x86: Add missing might_fault() from copy_{to,from}_user() |
| |
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> In x86-64, copy_to/from_user() rely on assembly routines that never > call might_fault(), making us missing various lockdep checks. > > This doesn't apply to __copy_from,to_user() that explicitly handle > these calls, neither is it a problem in x86-32 where > copy_to,from_user() rely on the "__" prefixed versions that also call > might_fault(). > > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> > --- > arch/x86/include/asm/uaccess_64.h | 10 +++++++++- > arch/x86/lib/copy_user_64.S | 4 ++-- > 2 files changed, 11 insertions(+), 3 deletions(-)
Looks good - other than that you missed the renaming of the symbol export line in arch/x86/kernel/x8664_ksyms_64.c, which i fixed.
Thanks,
Ingo
|  |