lkml.org 
[lkml]   [2009]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to &proc_dointvec,
From
Date
On Sun, 2009-11-15 at 09:11 +0100, Ingo Molnar wrote:
> * Am??rico Wang <xiyou.wangcong@gmail.com> wrote:
> > On Sat, Nov 14, 2009 at 05:52:05PM -0800, Joe Perches wrote:
> > >Seems to be a typo.
> > Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
> (Cc:-ed Eric who is running the sysctl tree these days)
> Almost everywhere in the kernel we use the shorter version, so all of
> sysctl.c should eventually change to that variant.

It's closer to 50/50, but it's 1 vs 133 in that file.

$ grep -Pr --include=*.[ch] '\.proc_handler\s*=\s*&\s*\w+' * | wc -l
339
$ grep -Pr --include=*.[ch] '\.proc_handler\s*=\s*[^&]\s*\w+' * | wc -l
432



\
 
 \ /
  Last update: 2009-11-15 09:31    [W:0.062 / U:0.584 seconds]
©2003-2014 Jasper Spaans. Advertise on this site