Messages in this thread | | | Date | Mon, 16 Nov 2009 00:37:06 +0100 | From | Frederic Weisbecker <> | Subject | Re: GPF in run_workqueue()/list_del_init(cwq->worklist.next) on resume (was: Re: Help needed: Resume problems in 2.6.32-rc, perhaps related to preempt_count leakage in keventd) |
| |
On Thu, Nov 12, 2009 at 06:33:00PM +0100, Thomas Gleixner wrote: > @@ -145,6 +255,7 @@ static void __queue_work(struct cpu_work > { > unsigned long flags; > > + debug_work_activate(work); > spin_lock_irqsave(&cwq->lock, flags); > insert_work(cwq, work, &cwq->worklist);
Since you are doing that from insert_wq_barrier too, which endpoint is also insert_work(), why not put debug_work_activate there instead? Or may be you really prefer to do this outside the spinlock (which in off-case is zero-overhead). May be that can sleep or?
| |