Messages in this thread | | | Date | Mon, 16 Nov 2009 00:25:02 +0100 | From | Samuel Ortiz <> | Subject | Re: [PATCH 1/2] mfd: pcf50633 - fix error handling during probe |
| |
On Mon, Nov 16, 2009 at 12:09:22AM +0100, Lars-Peter Clausen wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Dmitry Torokhov wrote: > > The pcf50633 is very naive - it assumes that all driver core > > operations will succeed and will fail badly if one of them > > errors out. Implement proper error handling and make sure we > > release any and all resources that have been allocated prior > > to failure. > > > > Also avoid memory leak when using platform_device_add_data() > > which clones the supplied data structure for use by the device. > > The original copy, if allocated dynamically, needs to be freed > > by the caller; switch to using on-stack variable (the size of > > the structure in question is quite small) instead. > > > > Signed-off-by: Dmitry Torokhov <dtor@mail.ru> > Hi > > Most of the issues addressed in this patch have already been fixed. > Please check the for-next branch in the mfd tree. Oops, thanks for refreshing our memories Lars...
Cheers, Samuel.
> - - Lars > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (GNU/Linux) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org > > iEYEARECAAYFAksAiiIACgkQBX4mSR26RiNJbACfYs4UhLSrlYuNqynJ/Mguw+oj > FxQAn2xmUh8QZttY4jxKUsdg+6p/pXNT > =yCtL > -----END PGP SIGNATURE----- >
-- Intel Open Source Technology Centre http://oss.intel.com/
| |