Messages in this thread | | | Date | Sun, 15 Nov 2009 22:34:10 +0100 (CET) | From | Julia Lawall <> | Subject | Re: [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to &proc_dointvec, |
| |
On Sun, 15 Nov 2009, Joe Perches wrote:
> On Sun, 2009-11-15 at 21:40 +0100, Julia Lawall wrote: > > On Sun, 15 Nov 2009, Joe Perches wrote: > > > On Sun, 2009-11-15 at 19:20 +0100, Julia Lawall wrote: > > > > Searching for things that are declared as functions (either a definition > > > > or a prototype), and then referenced as &f gives over 2000 results in > > > > almost 600 files. > > > Just curious, do you know how many are referenced > > > without the &? > > I got over 95000 (not checked in detail, though). > > Thanks. > > I think that ~25+:1 ratio makes a good case for an > eventual conversion of the remaining uses.
OK, I will try to look into it sometime soon.
> > > If what is desired is kernel wide consistent use, yes. > > > What I would like is file/subsystem consistent use. > > > > > > Looking at sysctl.c and seeing that different use > > > stand out was odd. > > > > It would be possible to count the number of occurrences in a given file, > > and then change the ones that have the less popular format, or a format > > that occurs less than some percentage of time. > > Maybe it'd be useful to add a coccinelle/spatch > directory in scripts and add these scripts so > that files and subsystems can updated over time. > > I can not find a directory of coccinelle input > scripts for linux at: > http://coccinelle.lip6.fr/download.php > Is there a list somewhere?
At the bottom of the download page there is a tool called coccicheck that runs Coccinelle on a set of semantic patches. It comes with a set of examples.
http://coccinelle.lip6.fr/distrib/coccicheck-0.1.tgz
julia
> Perhaps add a checkpatch test as well though > that might be an interesting test to write in > perl. > > >
| |