[lkml]   [2009]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to &proc_dointvec,
    On Sun, 2009-11-15 at 21:40 +0100, Julia Lawall wrote:
    > On Sun, 15 Nov 2009, Joe Perches wrote:
    > > On Sun, 2009-11-15 at 19:20 +0100, Julia Lawall wrote:
    > > > Searching for things that are declared as functions (either a definition
    > > > or a prototype), and then referenced as &f gives over 2000 results in
    > > > almost 600 files.
    > > Just curious, do you know how many are referenced
    > > without the &?
    > I got over 95000 (not checked in detail, though).


    I think that ~25+:1 ratio makes a good case for an
    eventual conversion of the remaining uses.

    > > If what is desired is kernel wide consistent use, yes.
    > > What I would like is file/subsystem consistent use.
    > >
    > > Looking at sysctl.c and seeing that different use
    > > stand out was odd.
    > It would be possible to count the number of occurrences in a given file,
    > and then change the ones that have the less popular format, or a format
    > that occurs less than some percentage of time.

    Maybe it'd be useful to add a coccinelle/spatch
    directory in scripts and add these scripts so
    that files and subsystems can updated over time.

    I can not find a directory of coccinelle input
    scripts for linux at:
    Is there a list somewhere?

    Perhaps add a checkpatch test as well though
    that might be an interesting test to write in

     \ /
      Last update: 2009-11-15 22:15    [W:0.025 / U:0.704 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site