lkml.org 
[lkml]   [2009]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6.32-rc6] sched, kvm: fix race condition involving sched_in_preempt_notifers
On 11/13/2009 11:55 AM, Ingo Molnar wrote:
> * Tejun Heo<tj@kernel.org> wrote:
>
>
>> In finish_task_switch(), fire_sched_in_preempt_notifiers() is called
>> after finish_lock_switch(). However, depending on architecture,
>> preemption can be enabled after finish_lock_switch() which breaks the
>> semantics of preempt notifiers. Move it before finish_arch_switch().
>> This also makes in notifiers symmetric to out notifiers in terms of
>> locking - now both are called under rq lock.
>>
>>
> I'd like to have Avi's Ack for it,

Acked-by: Avi Kivity <avi@redhat.com>

> but we want to do sched.c changes via
> the scheduler tree.
>

Definitely.

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.



\
 
 \ /
  Last update: 2009-11-14 14:11    [W:0.078 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site