lkml.org 
[lkml]   [2009]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6.32-rc6] sched, kvm: fix race condition involving sched_in_preempt_notifers

* Tejun Heo <tj@kernel.org> wrote:

> In finish_task_switch(), fire_sched_in_preempt_notifiers() is called
> after finish_lock_switch(). However, depending on architecture,
> preemption can be enabled after finish_lock_switch() which breaks the
> semantics of preempt notifiers. Move it before finish_arch_switch().
> This also makes in notifiers symmetric to out notifiers in terms of
> locking - now both are called under rq lock.
>
> NOT_SIGNED_OFF_YET
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Avi Kivity <avi@redhat.com>
> ---
> Avi, I think kvm should be fine with this but I haven't tested it.
> Does this look okay to you? If so, can you please route this through
> kvm tree with my signoff?

I'd like to have Avi's Ack for it, but we want to do sched.c changes via
the scheduler tree.

Ingo


\
 
 \ /
  Last update: 2009-11-13 10:59    [from the cache]
©2003-2011 Jasper Spaans