Messages in this thread | | | Date | Sat, 14 Nov 2009 02:20:47 -0200 | From | Henrique de Moraes Holschuh <> | Subject | Re: [ibm-acpi-devel] [PATCH v4 12/12] tree-wide: convert open calls to remove spaces to skip_spaces() lib function |
| |
On Sat, 07 Nov 2009, André Goddard Rosa wrote: > Also, while at it, if we see (*str && isspace(*str)), we can be sure to > remove the first condition (*str) as the second one (isspace(*str)) also > evaluates to 0 whenever *str == 0, making it redundant. In other words, > "a char equals zero is never a space".
You didn't document in isspace() that it must return false for NUL. Please do that before you remove any such checks.
-- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |