[lkml]   [2009]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [ibm-acpi-devel] [PATCH v4 12/12] tree-wide: convert open calls to remove spaces to skip_spaces() lib function
    On Sat, 07 Nov 2009, André Goddard Rosa wrote:
    > Also, while at it, if we see (*str && isspace(*str)), we can be sure to
    > remove the first condition (*str) as the second one (isspace(*str)) also
    > evaluates to 0 whenever *str == 0, making it redundant. In other words,
    > "a char equals zero is never a space".

    You didn't document in isspace() that it must return false for NUL. Please
    do that before you remove any such checks.

    "One disk to rule them all, One disk to find them. One disk to bring
    them all and in the darkness grind them. In the Land of Redmond
    where the shadows lie." -- The Silicon Valley Tarot
    Henrique Holschuh
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2009-11-14 05:25    [W:0.540 / U:6.516 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site