Messages in this thread |  | | | Date | Fri, 13 Nov 2009 20:38:03 +0100 | | Subject | Re: [PATCH 05/16] blkio: Implement per cfq group latency target and busy queue avg | | From | Corrado Zoccolo <> |
| |
On Fri, Nov 13, 2009 at 8:26 PM, Vivek Goyal <vgoyal@redhat.com> wrote: > On Fri, Nov 13, 2009 at 07:40:51PM +0100, Corrado Zoccolo wrote: >> Great. >> I have only one concern, regarding variable naming: >> group_target_lat is a bit misleading. The fact is that it will be >> larger for higher weight groups, so people could ask why are you >> giving more latency to higher weight group... >> Actually, it is the group share of the scheduling round, so you should >> name it accordingly. >> > > How about "group_slice" ? If you haven't something similar in other parts of the code, it will be fine
Corrado > > Thanks > Vivek > >
|  |