lkml.org 
[lkml]   [2009]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: Mark the thermal init functions __init
Yong Wang wrote:
> Mark the thermal init functions __init so that the init memory can be freed.
>
> Signed-off-by: Yong Wang <yong.y.wang@intel.com>
> ---
> arch/x86/kernel/cpu/mcheck/therm_throt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> index 7f3cf36..8a73d5c 100644
> --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
> +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> @@ -256,7 +256,7 @@ asmlinkage void smp_thermal_interrupt(struct pt_regs *regs)
> ack_APIC_irq();
> }
>
> -void mcheck_intel_therm_init(void)
> +void __init mcheck_intel_therm_init(void)
> {
> /*
> * This function is only called on boot CPU. Save the init thermal

It's OK because it is called only on BP.

> @@ -268,7 +268,7 @@ void mcheck_intel_therm_init(void)
> lvtthmr_init = apic_read(APIC_LVTTHMR);
> }
>
> -void intel_init_thermal(struct cpuinfo_x86 *c)
> +void __init intel_init_thermal(struct cpuinfo_x86 *c)
> {
> unsigned int cpu = smp_processor_id();
> int tm2 = 0;

But I think this could be called on hot-plugged AP.
Should be __cpuinit ?

void __cpuinit mcheck_cpu_init(struct cpuinfo_x86 *c)
-> static void __mcheck_cpu_init_vendor(struct cpuinfo_x86 *c)
-> void mce_intel_feature_init(struct cpuinfo_x86 *c)
-> void intel_init_thermal(struct cpuinfo_x86 *c)

Thanks,
H.Seto




\
 
 \ /
  Last update: 2009-11-12 06:31    [from the cache]
©2003-2011 Jasper Spaans