Messages in this thread Patch in this message |  | | | Date | Thu, 12 Nov 2009 18:15:43 -0500 | | From | Dave Jones <> | | Subject | Re: [PATCH] x86_64: Limit the number of processor bootup messages |
| |
On Thu, Nov 12, 2009 at 02:57:33PM -0800, H. Peter Anvin wrote: > On 11/12/2009 02:22 PM, Dave Jones wrote: > > > > But I don't disagree with Andi either, that it's not particularly useful, > > and we can get all this from userspace in /proc/cpuinfo, or x86info. > > > > I personally don't think it's useful at all. It gives information about > the processor which can be obtained from other sources. What we want is > enough information that the CPU can be unambiguously identified, so that > when someone posts dmesg we can tell what machine they came from.
In which case..
Dave
---
Remove the CPU cache size printk's.
They aren't useful, and pollute the dmesg output a lot (especially on machines with many cores). Also the same information can be trivially found out from userspace.
Signed-off-by: Dave Jones <davej@redhat.com>
diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c index 804c40e..868fcdd 100644 --- a/arch/x86/kernel/cpu/intel_cacheinfo.c +++ b/arch/x86/kernel/cpu/intel_cacheinfo.c @@ -488,22 +493,6 @@ unsigned int __cpuinit init_intel_cacheinfo(struct cpuinfo_x86 *c) #endif } - if (trace) - printk(KERN_INFO "CPU: Trace cache: %dK uops", trace); - else if (l1i) - printk(KERN_INFO "CPU: L1 I cache: %dK", l1i); - - if (l1d) - printk(KERN_CONT ", L1 D cache: %dK\n", l1d); - else - printk(KERN_CONT "\n"); - - if (l2) - printk(KERN_INFO "CPU: L2 cache: %dK\n", l2); - - if (l3) - printk(KERN_INFO "CPU: L3 cache: %dK\n", l3); - c->x86_cache_size = l3 ? l3 : (l2 ? l2 : (l1i+l1d)); return l2;
|  |