lkml.org 
[lkml]   [2009]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC] x86: fix confusing name of /proc/cpuinfo "ht" flag
On 11/12/2009 10:37 AM, Dave Jones wrote:
> On Thu, Nov 12, 2009 at 06:59:08PM +0100, Ingo Molnar wrote:
> > > It's an ABI. Keep it stable, please.
> >
> > That's generally true, but i'm not suggesting that: i'm suggesting to
> > _clear_ the HT flag from the cpufeatures if there's only one sibling.
> > It's meaningless in that case and as the link quoted by the original
> > patch shows many people are confused by that.
> >
> > I have such a box so i can test it. (but i dont expect any problems)
>
> I agree that it's an ABI change, but any software depending on its current
> state has to implement a fallback for the case where 'ht' isn't present anyway
> unless there's some program that only runs on ht capable hardware, which
> sounds just crazy.
>
> The only potential for breakage that I can see is that code that is tuned
> to be run in the HT case will stop running in cases where it shouldn't.
> Which sounds like a positive thing to me.

The most likely breakage would be some stupid licensing scheme.

The other aspect is that we as much as possible have tried to stay to
the hardware-documented names of these strings. Inventing new strings
is generally a bad idea.

-hpa



\
 
 \ /
  Last update: 2009-11-12 20:53    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site