Messages in this thread | | | Date | Thu, 12 Nov 2009 19:21:08 +0100 | From | Patrick McHardy <> | Subject | Re: [PATCH] netdevice: provide common routine for macvlan and vlan operstate management |
| |
Patrick Mullaney wrote: > This patch is intended to address your comment on moving the operstate > transition function. I decided to move it to netdevice.h, perhaps that > is a bad idea? It didn't seem to logically fall into dev.c or link_watch.c. > I am not against moving them to either one though. Your other comments > are addressed and I will send out a second series once this gets > reviewed and agreed on.
Thanks. I don't mind much where exactly it is located, but I'd prefer to not have it inlined. It doesn't seem terribly wrong to move it to dev.c, there are even some helpers for stacked devices already, like address list synchronization.
Besides that the patch looks fine to me.
| |