lkml.org 
[lkml]   [2009]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC] x86: fix confusing name of /proc/cpuinfo "ht" flag

* H. Peter Anvin <hpa@zytor.com> wrote:

> On 11/12/2009 12:13 AM, Ingo Molnar wrote:
> >>
> >> /proc/cpuinfo is a user-space visible ABI. Changing it is bad
> >> chicken.
> >
> > Almost ... something is only an ABI if an actual application relies on
> > the 'ht' flag being there on non-hyperthreading CPUs. We dont know
> > whether there's any, but the likelyhood looks pretty low. Could park it
> > a branch for some time to see whether anything trips up.
> >
>
> No, please. We have had people who have "helpfully" tried to change
> /proc/cpuinfo in the past, and what we find is that application
> developers don't tell us -- they grumble among themselves and put out
> a new release saying "fixes breakage introduced by Linux ..."
>
> It's an ABI. Keep it stable, please.

That's generally true, but i'm not suggesting that: i'm suggesting to
_clear_ the HT flag from the cpufeatures if there's only one sibling.
It's meaningless in that case and as the link quoted by the original
patch shows many people are confused by that.

I have such a box so i can test it. (but i dont expect any problems)

Ingo


\
 
 \ /
  Last update: 2009-11-12 19:01    [W:0.752 / U:0.648 seconds]
©2003-2014 Jasper Spaans. Advertise on this site