Messages in this thread | | | Date | Wed, 11 Nov 2009 20:05:03 +0000 | From | Matthew Garrett <> | Subject | Re: [PATCH] pci: Updates to Rafael's runtime PCI PM patch set |
| |
On Wed, Nov 11, 2009 at 08:58:20PM +0100, Rafael J. Wysocki wrote:
> The PME was supposed to be turned on by pci_prepare_to_sleep(). > I guess it wasn't in practice?
Only if the device is set as a wakeup device, which seems messy. Though there may need to be a check there to avoid duplicate PME setup.
> Generally, some parts of it belong to the > "PCI PM: Run-time callbacks for PCI bus type" patch and the others belong > to "PCI / ACPI PM: Platform support for PCI PME wake-up" patch. Should I fold > the changes into them?
Feel free!
-- Matthew Garrett | mjg59@srcf.ucam.org
| |