lkml.org 
[lkml]   [2009]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [BUGFIX][PATCH] oom-kill: fix NUMA consraint check with nodemask v2
    On Tue, 10 Nov 2009 16:40:55 +0900, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
    > On Tue, 10 Nov 2009 16:39:02 +0900 (JST)
    > KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
    >
    > > > > > +
    > > > > > + /* Check this allocation failure is caused by cpuset's wall function */
    > > > > > + for_each_zone_zonelist_nodemask(zone, z, zonelist,
    > > > > > + high_zoneidx, nodemask)
    > > > > > + if (!cpuset_zone_allowed_softwall(zone, gfp_mask))
    > > > > > return CONSTRAINT_CPUSET;
    > > > >
    > > > > If cpuset and MPOL_BIND are both used, Probably CONSTRAINT_MEMORY_POLICY is
    > > > > better choice.
    > > >
    > > > No. this memory allocation is failed by limitation of cpuset's alloc mask.
    > > > Not from mempolicy.
    > >
    > > But CONSTRAINT_CPUSET doesn't help to free necessary node memory. It isn't
    > > your fault. original code is wrong too. but I hope we should fix it.
    > >
    I think so too.

    > Hmm, maybe fair enough.
    >
    > My 3rd version will use "kill always current(CONSTRAINT_MEMPOLICY does this)
    > if it uses mempolicy" logic.
    >
    "if it uses mempoicy" ?
    You mean "kill allways current if memory allocation has failed by limitation of
    cpuset's mask"(i.e. CONSTRAINT_CPUSET case) ?


    Thanks,
    Daisuke Nishimura.


    \
     
     \ /
      Last update: 2009-11-10 09:07    [from the cache]
    ©2003-2014 Jasper Spaans. Advertise on this site