lkml.org 
[lkml]   [2009]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC, PATCH] cfq-iosched: remove redundant queuing detection code
Date
Jens Axboe <jens.axboe@oracle.com> writes:

> On Tue, Nov 10 2009, Corrado Zoccolo wrote:
>> The core block layer already has code to detect presence of command
>> queuing devices. We convert cfq to use that instead of re-doing the
>> computation.
>
> There's is the major difference that the CFQ variant is dynamic and the
> block layer one is not. This change came from Aaron some time ago IIRC,
> see commit 45333d5. It's a bit of a chicken and egg problem.

Really? blk_dequeue_request sure looks like it updates things
dynamically, but only one way (not queueing -> queueing). Would it make
sense to just put CFQ's logic into the block layer so that everyone uses
the same implementation? It makes little sense to have two notions of
whether or not queueing is supported for a device.

Cheers,
Jeff


\
 
 \ /
  Last update: 2009-11-10 16:23    [W:0.096 / U:0.012 seconds]
©2003-2014 Jasper Spaans. Advertise on this site