Messages in this thread |  | | | Date | Tue, 10 Nov 2009 13:08:49 +0000 | | From | Mark Brown <> | | Subject | Re: [PATCH 2/2] regulator/mc13783: various cleanups |
| |
On Tue, Nov 10, 2009 at 09:18:07AM +0100, Uwe Kleine-König wrote: > - define needed registers and bits in the driver > - properly namespace functions and structs > - fix locking as required by patch > "mfd/mc13783: near complete rewrite" > - use platform_data as provided by "mfd/mc13783: near complete rewrite" > instead of accessing struct mc13783 > - struct mc13783_regulator_priv.desc is (and was) unused and so can go > away > - use cpp magic to initialize mc13783_regulators > - bring MODULE_LICENSE in sync with actual copyright > - minor style fixes > > This allows not including mc13783-private.h which I intend to remove > soon.
Acked-by: Mark Brown <broonie@opensoruce.wolfsonmicro.com>
It'd have been a bit easier to review if done as more patches - eg, the change to use macros to define the regulators could've been done as a separate patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |