[lkml]   [2009]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] vsprintf: reduce code size, clean up
    Hi, Frederic!

    On Sun, Nov 1, 2009 at 8:45 PM, Frederic Weisbecker <> wrote:
    > On Sun, Nov 01, 2009 at 03:01:40PM -0200, André Goddard Rosa wrote:
    >> +static char null[] = "(null)";
    >> +
    > This should be static const.
    > Also, may be chose a better name, as "null" is too much
    > generic and somehow collide with NULL.
    > null_str ?

    If I make it a "static const" it's necessary to cast it in two places
    to "char *" and code size goes up

    lib/vsprintf.c: In function ‘string’:
    lib/vsprintf.c:556: warning: assignment discards qualifiers from
    pointer target type
    lib/vsprintf.c: In function ‘pointer’:
    lib/vsprintf.c:828: warning: passing argument 3 of ‘string’ discards
    qualifiers from pointer target type
    lib/vsprintf.c:551: note: expected ‘char *’ but argument is of type
    ‘const char *’

    text data bss dec hex filename
    15383 7 8 15398 3c26 lib/vsprintf.o-static-before
    15431 0 8 15439 3c4f lib/vsprintf.o-static-const-after

    as it moves the variable from data section to code section. Is this
    the preferred method?

    Thanks for reviewing! I'll fix the other points per your suggestions
    and post back.

    With regards,
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2009-11-02 00:03    [W:0.036 / U:1.568 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site