lkml.org 
[lkml]   [2009]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2][v2] mm: add notifier in pageblock isolation for balloon drivers
    * Andrew Morton (akpm@linux-foundation.org) wrote:
    > On Fri, 2 Oct 2009 13:44:58 -0500
    > Robert Jennings <rcj@linux.vnet.ibm.com> wrote:
    >
    > > Memory balloon drivers can allocate a large amount of memory which
    > > is not movable but could be freed to accomodate memory hotplug remove.
    > >
    > > Prior to calling the memory hotplug notifier chain the memory in the
    > > pageblock is isolated. If the migrate type is not MIGRATE_MOVABLE the
    > > isolation will not proceed, causing the memory removal for that page
    > > range to fail.
    > >
    > > Rather than failing pageblock isolation if the the migrateteype is not
    > > MIGRATE_MOVABLE, this patch checks if all of the pages in the pageblock
    > > are owned by a registered balloon driver (or other entity) using a
    > > notifier chain. If all of the non-movable pages are owned by a balloon,
    > > they can be freed later through the memory notifier chain and the range
    > > can still be isolated in set_migratetype_isolate().
    >
    > The patch looks sane enough to me.
    >
    > I expect that if the powerpc and s390 guys want to work on CMM over the
    > next couple of months, they'd like this patch merged into 2.6.32. It's
    > a bit larger and more involved than one would like, but I guess we can
    > do that if suitable people (Mel? Kamezawa?) have had a close look and
    > are OK with it.
    >
    > What do people think?

    I'd love to get it in 2.6.32 if that's possible. I have gone over the
    comments from Mel and Kamezawa I produced a new patchset. I just
    finished testing it (and I also tested with
    CONFIG_MEMORY_HOTPLUG_SPARSE=n) and it will be posted shortly.

    >
    > Has it been carefully compile- and run-time tested with
    > CONFIG_MEMORY_HOTPLUG_SPARSE=n?

    Yes, I have compiled the kernel CONFIG_MEMORY_HOTPLUG_SPARSE=n and made
    sure that we didn't have any problems.

    --Robert Jennings


    \
     
     \ /
      Last update: 2009-10-09 22:29    [W:0.034 / U:121.636 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site