Messages in this thread | | | Date | Fri, 9 Oct 2009 13:43:24 -0400 | From | James Smart <> | Subject | Re: [PATCH -repost 3/4] SCSI: lpfc, fix memory leak |
| |
Acked-by: James Smart <james.smart@emulex.com>
-- james s
Jiri Slaby wrote: > Stanse found a memory leak on one fail path in lpfc_sli4_read_rev. > > Add there kfree. > > Signed-off-by: Jiri Slaby <jirislaby@gmail.com> > Cc: James Smart <james.smart@emulex.com> > Cc: James E.J. Bottomley <James.Bottomley@suse.de> > --- > drivers/scsi/lpfc/lpfc_sli.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c > index 43cbe33..7750868 100644 > --- a/drivers/scsi/lpfc/lpfc_sli.c > +++ b/drivers/scsi/lpfc/lpfc_sli.c > @@ -4211,6 +4211,7 @@ lpfc_sli4_read_rev(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq, > if (rc) { > dma_free_coherent(&phba->pcidev->dev, dma_size, > dmabuf->virt, dmabuf->phys); > + kfree(dmabuf); > return -EIO; > } > >
| |