lkml.org 
[lkml]   [2009]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] Fix memory leak of never putback pages in mbind()
On Fri, 9 Oct 2009, KOSAKI Motohiro wrote:

> Oops, I forgot to remove unnecessary brace.
> updated patch is here.

Thats a style issue. There are other weird things in do_mbind as well
like starting a new block in the middle of another.

Having

}
{

in a program is a bit confusing. So could you do a cleanup patch for
mpol_bind? Preferably it should make it easy to read to and bring some
order to the confusing error handling.



\
 
 \ /
  Last update: 2009-10-09 16:03    [W:0.089 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site