Messages in this thread | | | Subject | Re: [PATCH] kernel/time/tick-sched.c: fix warning of printk's argument format | From | Wu Zhangjin <> | Date | Thu, 08 Oct 2009 23:31:43 +0800 |
| |
On Thu, 2009-10-08 at 08:03 -0700, Linus Torvalds wrote: > > On Thu, 8 Oct 2009, Wu Zhangjin wrote: > > > > This patch will fix the following warning: > > No it won't. It will add a lot of new warnings. > > The thing is, almost all architectures (including x86) have > > unsigned int __softirq_pending; > > but then in <asm-generic/hardirq.h> we have > > unsigned long __softirq_pending; > > for some unfathomable reason. Quite frankly, I think Arnd just screwed up > the "generic" version, and the fix is almost certainly to just make the > generic version match all the main architectures. > > I don't have any architectures using the generic header file, though, so > I'm not going to do that change blindly. People who do should look at it > (alpha, powerpc and mips look like the only ones that might be 64-bit, but > I didn't check very carefully - just grepped for it) > > Added Cc's for some people that have worked on, or used, that generic > header file. Is there any possible reason why it is "unsigned long" in > that one? >
I'm really using a MIPS machine! there is only a "unsigned long" definition in include/asm-generic/hardirq.h.
Regards, Wu Zhangjin
| |