Messages in this thread |  | | | Date | Wed, 7 Oct 2009 09:38:06 +0200 | | From | Pavel Machek <> | | Subject | Re: [TOMOYO #16 00/25] Starting TOMOYO 2.3 |
| |
On Wed 2009-10-07 13:09:24, Tetsuo Handa wrote: > Hello. > > Pavel Machek wrote: > >> Since this patchset is not yet accepted, I haven't written documentation for > >> TOMOYO 2.3. You can see http://tomoyo.sourceforge.jp/1.7/policy-reference.html > >> instead. > > > >New, undocumented user/kernel api is no-no. > > I'll update api description by final submission.
Well, then you'll get proper review by final submission.
> >> Conventionally, patches should be submitted in the form of diff file. > >> But this time, I submit in the form of entire file due to amount of changes. > > > > That's also no-no. > > I have a question. > Is the diff file based on existing files more preferable for reviewers to > review than totally rewritten files, even if "total lines of diff files" is > close to "total lines of rewritten files"?
You are expected to submit diffs in smaller steps, not "here it is, totally rewritten, take it or leave it". Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
|  |