lkml.org 
[lkml]   [2009]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC][PATCH] perf tools: Merge trace.info content into perf.data
From
Date
On Tue, 2009-10-06 at 23:36 +0200, Frederic Weisbecker wrote:
> Hi,
>
> Here is an attempt to remove the trace.info file.
> It works well for me, the reason for it to be an RFC
> is that I have doubts about the backward compatibility.
>
> A file created by perf after his patch is unsupported
> by previous version because the size of the headers have
> increased.
>
> That said, it's two new fields that have been added in
> the end of the headers, and those could be ignored by
> previous versions if they just handled the dynamic header
> size and then ignore the unknow part. The offsets guarantee
> the compatibility.
> But previous versions handle the header size using its
> static size, not dynamic, then it's not backward compatible.
>
> Anyway, I'm not sure exactly how to handle that.

If we're still able to read 'regular' old perf.data files after this.
That is, allow to read short headers and assume the tail is 0 we'll be
good. (this will break trace files that rely on the now removed
trace.info, but that's unavoidable I guess).

So backwards compatible, but no fwd compat for the old perf.


\
 
 \ /
  Last update: 2009-10-07 08:51    [W:0.061 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site