lkml.org 
[lkml]   [2009]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] isicom: switch to the new tty_port_open helper
On 10/07/2009 04:46 PM, Alan Cox wrote:
> - if (port->port.flags & ASYNC_INITIALIZED)
> - return 0;
> - if (tty_port_alloc_xmit_buf(&port->port) < 0)
> + if (tty_port_alloc_xmit_buf(tport) < 0)

I think this won't work well with 1/4. ->activate is called with
port->port.mutex (the name in this context), but tty_port_alloc_xmit_buf
wants it again.


\
 
 \ /
  Last update: 2009-10-07 22:17    [W:0.193 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site