lkml.org 
[lkml]   [2009]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] perf tools: Merge trace.info content into perf.data

* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> Hi,
>
> Here is an attempt to remove the trace.info file. It works well for
> me, the reason for it to be an RFC is that I have doubts about the
> backward compatibility.
>
> A file created by perf after his patch is unsupported by previous
> version because the size of the headers have increased.

That's OK i think in terms of trace.info - trace.info was a temporary
hack to begin with.

> That said, it's two new fields that have been added in the end of the
> headers, and those could be ignored by previous versions if they just
> handled the dynamic header size and then ignore the unknow part. The
> offsets guarantee the compatibility.

Yes, that's how it should work.

> But previous versions handle the header size using its static size,
> not dynamic, then it's not backward compatible.
>
> Anyway, I'm not sure exactly how to handle that.

That's a bug in the previous version - mind doing a standalone fix for
that so we can mark it Cc: stable?

Thanks,

Ingo


\
 
 \ /
  Last update: 2009-10-07 08:27    [W:0.145 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site