[lkml]   [2009]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [this_cpu_xx V5 19/19] SLUB: Experimental new fastpath w/o interrupt disable
    On Wed, 7 Oct 2009, Mathieu Desnoyers wrote:

    > Yes, I understood this is what he was doing, but I wonder about the
    > impact on the scheduler. If we have:
    > * Jiffy 1 -- timer interrupt
    > * preempt disable
    > * Jiffy 2 -- timer interrupt
    > -> here, the scheduler is disabled, so the timer interrupt is skipped.
    > The scheduler depends on preempt_check_resched() at preempt_enable()
    > to execute in a bounded amount of time.

    preempt disable does not disable interrupts. The timer interrupt will
    occur. The scheduler may not reschedule another job on this processor
    when the timer interrupt calls the scheduler_tick. It
    may not do load balancing.

    > Also, preempt_enable here should be replaced with
    > preempt_enable_no_resched().

    Used to have that in earlier incarnations but I saw a lot of these being
    removed lately.

     \ /
      Last update: 2009-10-07 17:11    [W:3.222 / U:0.604 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site