lkml.org 
[lkml]   [2009]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUG] isicom.c sleeping function called from invalid context
On Wed, 7 Oct 2009 17:15:14 +0000
Alexander Strakh <strakh@ispras.ru> wrote:

> KERNEL_VERSION: 2.6.31
> DESCRIBE:
> Driver drivers/char/isicom.c might sleep in atomic context, because it calls
> tty_port_xmit_buf under spin_lock.
>
> ./drivers/char/isicom.c:
> 1307 static void isicom_hangup(struct tty_struct *tty)
> 1308 {
> ...
> 1315 spin_lock_irqsave(&port->card->card_lock, flags);
> 1316 isicom_shutdown_port(port);
> ...
>
> Path to might_sleep macro from isicom_hangup:
> 1. isicom_hangup calls spin_lock_irqsave (drivers/char/isicom.c:1315) and then
> calls isicom_shutdown_port.
> 2. isiscom_shutdown_port calls tty_port_free_xmit_buf at
> drivers/char/isicom.c:906
> 3. tty_port_free_xmit_buf calls mutex_lock at srivers/char/tty_port:48

Ok that's fairly easy to fix once the tty_port_open patch is applied



\
 
 \ /
  Last update: 2009-10-07 16:59    [W:0.061 / U:1.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site