lkml.org 
[lkml]   [2009]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/5] checkpatch: add a blacklist
Date
Daniel Walker <dwalker@fifo99.com> writes:

>>From my perspective Documentation/SubmittingPatches really dictates what
> you should be doing with checkpatch, since that was signed off on by
> Andy (on this thread) and Linus .. In that document I think checkpatch
> is given authority, rather than what your suggesting where it's just
> something you can use or not, and ignore or not like it has no meaning
> at all..

Checkpatch is a tool. How a tool can have authority? Code authors can
have authority. Maintainers can have authority. Linus as the "top"
maintainer can have authority. But a tool?

If checkpatch had any authority, the file in question (ext4.h) would
have to be "fixed" without questions and exceptions.

I don't say its warnings and errors have no meaning at all. It may be
very helpful at times, but still it's only a tool.
--
Krzysztof Halasa


\
 
 \ /
  Last update: 2009-10-07 16:59    [W:0.094 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site