lkml.org 
[lkml]   [2009]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/7] x86 dumpstack: fix printing of stack dump loglevels


On Wed, 7 Oct 2009, Alan Jenkins wrote:
>
> Changing printk() to accept loglevels in the middle of the string again
> would be non-trivial. Let's accept this limitation and simply split the
> above code into two separate calls to printk().

Actually, let's just drop the log_lvl printout in the middle.

And to do that, let's clean up printk() a bit further - just make it say
"if there is no loglevel, use the previous loglevel". That's going to
simplify _all_ kinds of multi-line code.

As far as I can tell, that's a oneliner: make 'current_log_level' be a
'static' variable.

Wouldn't that be much simpler for everybody?

(And yes, if you mix multi-line messages that are printed as separate
printk's and with different loglevels, output will be confused. But quite
frankly, it will be confused regardless)

Linus


\
 
 \ /
  Last update: 2009-10-18 23:28    [W:0.821 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site