| | Date | Wed, 7 Oct 2009 22:23:30 +0800 | | From | Wu Fengguang <> | | Subject | Re: [PATCH 09/45] writeback: quit on wrap for .range_cyclic (pohmelfs) |
| |
On Wed, Oct 07, 2009 at 08:32:11PM +0800, Evgeniy Polyakov wrote: > Hi. > > On Wed, Oct 07, 2009 at 03:38:27PM +0800, Wu Fengguang (fengguang.wu@intel.com) wrote: > > Convert wbc.range_cyclic to new behavior: when past EOF, abort writeback > > of the inode, which instructs writeback_single_inode() to delay it for > > a while if necessary. > > > > It removes one inefficient .range_cyclic IO pattern when writeback_index > > wraps: > > submit [10000-10100], (wrap), submit [0-100] > > In which the submitted pages may be consisted of two distant ranges. > > > > It also prevents submitting pointless IO for busy overwriters. > > I have no objections against this patchset, since I followed the > upstream writeback behaviour and did not personally observe such wraps > which would be otherwise handled in a single run.
OK, thanks!
Fengguang
|