lkml.org 
[lkml]   [2009]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/45] writeback: quit on wrap for .range_cyclic (pohmelfs)
Hi.

On Wed, Oct 07, 2009 at 03:38:27PM +0800, Wu Fengguang (fengguang.wu@intel.com) wrote:
> Convert wbc.range_cyclic to new behavior: when past EOF, abort writeback
> of the inode, which instructs writeback_single_inode() to delay it for
> a while if necessary.
>
> It removes one inefficient .range_cyclic IO pattern when writeback_index
> wraps:
> submit [10000-10100], (wrap), submit [0-100]
> In which the submitted pages may be consisted of two distant ranges.
>
> It also prevents submitting pointless IO for busy overwriters.

I have no objections against this patchset, since I followed the
upstream writeback behaviour and did not personally observe such wraps
which would be otherwise handled in a single run.

> CC: Evgeniy Polyakov <zbr@ioremap.net>
> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>

--
Evgeniy Polyakov


\
 
 \ /
  Last update: 2009-10-07 14:41    [from the cache]
©2003-2011 Jasper Spaans