Messages in this thread | | | Date | Wed, 07 Oct 2009 13:20:36 +0100 | From | "Jan Beulich" <> | Subject | Re: [PATCH] adjust gfp mask passed on nested vmalloc() invocation |
| |
>>> Hugh Dickins <hugh.dickins@tiscali.co.uk> 07.10.09 14:08 >>> >Well, now we've accepted that this code cannot be used in_interrupt(), >there's no need for your #ifdef CONFIG_HIGHMEM nor for my memset: just >use __GFP_ZERO as it was before, and your patch would amount to or'ing >__GFP_HIGHMEM into gfp_mask for the __vmalloc_node case - wouldn't it?
Plus the consolidation of masking the passed in gfp_mask by GFP_RECLAIM_MASK also for the nested vmalloc() case, in particular to remove the GFP_DMA* possibly coming in from vmalloc_32(). But yes, it will become simpler.
Jan
| |