lkml.org 
[lkml]   [2009]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/5] checkpatch: add a blacklist
From
Date
On Tue, 2009-10-06 at 22:50 +0200, Krzysztof Halasa wrote:
> Daniel Walker <dwalker@fifo99.com> writes:
>
> > In terms of the list getting long or not, your basically in control of
> > it since you maintain checkpatch .. If you leave it without some sort of
> > blacklist, then you end up with whole sections of code where the
> > developers don't use checkpatch at all (or very little)..
>
> Why? I routinely ignore specific warnings from checkpatch while paying
> attention to other ones. That's precisely what one should expect if the
> code in question technically violates the common style (or whatever is
> it). I don't think we need exceptions in the checkpatch as they would
> make it less useful and less reliable.

This thread is specifically about checkpatch errors .. checkpatch
warnings can be ignored, but errors you can't usually ignore.. If your
ignoring errors then either checkpatch is producing bogus output that
needs to be corrected, or it's something you really should fix..

Daniel



\
 
 \ /
  Last update: 2009-10-07 06:01    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site