lkml.org 
[lkml]   [2009]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] Revert "Revert "ide: try to use PIO Mode 0 during probe if possible""
Date
On Wednesday 07 October 2009 00:41:20 David Miller wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Date: Wed, 7 Oct 2009 00:27:45 +0200
>
> > The root cause of reported system hangs was (now fixed) sis5513 bug
> > and not "ide: try to use PIO Mode 0 during probe if possible" change
> > (commit 6029336426a2b43e4bc6f4a84be8789a047d139e) so the revert was
> > incorrect (it simply replaced one regression with the other one).
>
> What is this older "regression" fixed by the PIO-0 change?
>
> You're not explaining it and neither does the commit message for the
> PIO-0 change.

It does:

| Subject: [PATCH] sis5513: fix PIO setup for ATAPI devices
|
| Clear prefetch setting before potentially (re-)enabling it in
| config_drive_art_rwp() so the transition of the device type on
| the port from ATA to ATAPI (i.e. during warm-plug operation)
| is handled correctly.

and the empty port defaults to ATA-like behavior for the initial PIO setup.

> Please, fill us in :-)

Just connect the dots.. :)


\
 
 \ /
  Last update: 2009-10-07 01:01    [W:0.036 / U:0.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site