Messages in this thread | | | Date | Tue, 6 Oct 2009 20:49:11 +0200 | From | Ingo Molnar <> | Subject | Re: [patch] kbuild: Improve version string logic |
| |
* Johannes Berg <johannes@sipsolutions.net> wrote:
> On Tue, 2009-10-06 at 19:35 +0200, Ingo Molnar wrote: > > > It changes how CONFIG_LOCALVERSION_AUTO works, in the following trivial > > way: > > > > - if it is set, things work the way they always have, and you get a > > extended kernel release like: > > > > 2.6.32-rc3+00052-g0eca52a-dirty > > > > ( with the difference that the extra version string is separated via > > '+' not via '-'. This improves visibility when we have additional > > changes over a vanilla tag. ) > > I really don't see how it improves visibility (unless you're oblivious > to the difference between long and short strings), but I do know that > I have a few parsers that this will break.
It improves visibility the same way the + at the end of the short version improves visibility.
That said, i'm perfectly fine with just having the short version include the '+' sign (i.e. Linus's original patch), that was my original suggestion and that is already a big step forward.
Thanks,
Ingo
| |